Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add arXiv classes to journals #720

Merged
merged 1 commit into from
Sep 4, 2018
Merged

Do not add arXiv classes to journals #720

merged 1 commit into from
Sep 4, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Sep 3, 2018

Already did {{cite journal}}
Adding {{citation | journal=something}}

@codecov
Copy link

codecov bot commented Sep 3, 2018

Codecov Report

Merging #720 into master will decrease coverage by 1.6%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #720      +/-   ##
============================================
- Coverage     68.66%   67.06%   -1.61%     
- Complexity     1622     1623       +1     
============================================
  Files            12       12              
  Lines          3217     3218       +1     
============================================
- Hits           2209     2158      -51     
- Misses         1008     1060      +52
Impacted Files Coverage Δ Complexity Δ
Template.php 73.09% <100%> (-2.54%) 1452 <0> (+1)
expandFns.php 90.71% <0%> (+0.71%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dfa5ba...93613bc. Read the comment docs.

@GlazerMann GlazerMann changed the title Do not want class in for journals Do not add arXiv classes to journals Sep 4, 2018
@ms609 ms609 merged commit 1a828b4 into ms609:master Sep 4, 2018
@GlazerMann GlazerMann deleted the patch-1 branch September 4, 2018 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants