Doi's with square brackets cannot search PUBMED #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
============================================
- Coverage 68.71% 67.11% -1.61%
- Complexity 1623 1624 +1
============================================
Files 12 12
Lines 3222 3223 +1
============================================
- Hits 2214 2163 -51
- Misses 1008 1060 +52
Continue to review full report at Codecov.
|
|
Should a similar change be made in apiFunctions.php, to avoid passing [] dois to the batch pubmed search? |
ms609
approved these changes
Sep 5, 2018
|
I do not think that the current code in apiFunctions.php searches based upon doi. I might be wrong |
|
Ah yes, that's right. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.