Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove <X> </X> that can have unmatched {{ & }} inside #733

Merged
merged 5 commits into from
Sep 11, 2018
Merged

Remove <X> </X> that can have unmatched {{ & }} inside #733

merged 5 commits into from
Sep 11, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Sep 6, 2018

This bug report relates to parsing page Fouling

@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

Merging #733 into master will decrease coverage by 1.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #733     +/-   ##
=========================================
- Coverage      69.3%    68%   -1.3%     
- Complexity     1621   1629      +8     
=========================================
  Files            12     12             
  Lines          3264   3294     +30     
=========================================
- Hits           2262   2240     -22     
- Misses         1002   1054     +52
Impacted Files Coverage Δ Complexity Δ
Comment.php 100% <100%> (ø) 12 <8> (+8) ⬆️
Page.php 74.39% <100%> (+1.02%) 70 <0> (ø) ⬇️
Template.php 73.52% <0%> (-2.57%) 1450% <0%> (ø)
apiFunctions.php 68.04% <0%> (+0.53%) 0% <0%> (ø) ⬇️
expandFns.php 90.71% <0%> (+0.71%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee53e0e...3bb4425. Read the comment docs.

@GlazerMann GlazerMann changed the title Remove <chem> & <math>: can have unmatched {{ & }} Remove <X> </X> that can have unmatched {{ & }} inside Sep 7, 2018
Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; can we add a test please?
Ideally tests should mirror bug reports so that we can be confident that the bug will be caught if it recurs durhing future refactoring.

@GlazerMann
Copy link
Collaborator Author

I did add a test. Just to the wrong branch. I will add one to this branch now!

@GlazerMann
Copy link
Collaborator Author

@ms609 Tests are now added (I cannot add the actual example since it huge file).

@ms609
Copy link
Owner

ms609 commented Sep 11, 2018

Nice minimal test, thanks!

@ms609 ms609 merged commit 13c9c35 into ms609:master Sep 11, 2018
@GlazerMann GlazerMann deleted the patch-10 branch September 11, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants