-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove <X> </X> that can have unmatched {{ & }} inside #733
Conversation
Codecov Report
@@ Coverage Diff @@
## master #733 +/- ##
=========================================
- Coverage 69.3% 68% -1.3%
- Complexity 1621 1629 +8
=========================================
Files 12 12
Lines 3264 3294 +30
=========================================
- Hits 2262 2240 -22
- Misses 1002 1054 +52
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good; can we add a test please?
Ideally tests should mirror bug reports so that we can be confident that the bug will be caught if it recurs durhing future refactoring.
I did add a test. Just to the wrong branch. I will add one to this branch now! |
@ms609 Tests are now added (I cannot add the actual example since it huge file). |
Nice minimal test, thanks! |
This bug report relates to parsing page Fouling