Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sanitize_doi() do a lot more to dois #737

Merged
merged 10 commits into from
Sep 12, 2018
Merged

make sanitize_doi() do a lot more to dois #737

merged 10 commits into from
Sep 12, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Sep 7, 2018

This time I made test first

@GlazerMann GlazerMann changed the title Fix/test soi endings Fix/test doi endings Sep 7, 2018
@codecov
Copy link

codecov bot commented Sep 7, 2018

Codecov Report

Merging #737 into master will decrease coverage by 0.86%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #737      +/-   ##
============================================
- Coverage     69.35%   68.49%   -0.87%     
- Complexity     1621     1634      +13     
============================================
  Files            12       12              
  Lines          3270     3314      +44     
============================================
+ Hits           2268     2270       +2     
- Misses         1002     1044      +42
Impacted Files Coverage Δ Complexity Δ
expandFns.php 90.97% <100%> (+0.97%) 0 <0> (ø) ⬇️
Template.php 73.84% <0%> (-2.25%) 1454% <0%> (+4%)
Comment.php 100% <0%> (ø) 12% <0%> (+8%) ⬆️
Page.php 74.64% <0%> (+1.28%) 71% <0%> (+1%) ⬆️
apiFunctions.php 70.02% <0%> (+1.98%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6983395...81369dc. Read the comment docs.

@ms609
Copy link
Owner

ms609 commented Sep 10, 2018

I feel like this duplicates code that already exists elsewhere – am I right? If so, is there a way to avoid the duplication?

@GlazerMann
Copy link
Collaborator Author

GlazerMann commented Sep 10, 2018

This code is duplicated in parts around the source base. By putting it all here, we do not need the other bits most likely. Those other parts are now fixed and use sanitize_doi().

@GlazerMann GlazerMann changed the title Fix/test doi endings sanitize_doi Sep 10, 2018
@GlazerMann GlazerMann changed the title sanitize_doi make sanitize_doi() do a lot more to dois Sep 10, 2018
expandFns.php Outdated Show resolved Hide resolved
@ms609 ms609 merged commit 7e084bf into ms609:master Sep 12, 2018
@GlazerMann GlazerMann deleted the patch-18 branch September 19, 2018 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants