-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make sanitize_doi() do a lot more to dois #737
Conversation
Codecov Report
@@ Coverage Diff @@
## master #737 +/- ##
============================================
- Coverage 69.35% 68.49% -0.87%
- Complexity 1621 1634 +13
============================================
Files 12 12
Lines 3270 3314 +44
============================================
+ Hits 2268 2270 +2
- Misses 1002 1044 +42
Continue to review full report at Codecov.
|
I feel like this duplicates code that already exists elsewhere – am I right? If so, is there a way to avoid the duplication? |
This code is duplicated in parts around the source base. By putting it all here, we do not need the other bits most likely. Those other parts are now fixed and use sanitize_doi(). |
This time I made test first