Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pointless default parameter from CS1 #740

Merged
merged 3 commits into from
Sep 10, 2018
Merged

remove pointless default parameter from CS1 #740

merged 3 commits into from
Sep 10, 2018

Conversation

GlazerMann
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 8, 2018

Codecov Report

Merging #740 into master will decrease coverage by 1.54%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #740      +/-   ##
============================================
- Coverage     69.35%   67.81%   -1.55%     
- Complexity     1621     1625       +4     
============================================
  Files            12       12              
  Lines          3270     3275       +5     
============================================
- Hits           2268     2221      -47     
- Misses         1002     1054      +52
Impacted Files Coverage Δ Complexity Δ
Template.php 73.59% <100%> (-2.5%) 1454 <0> (+4)
expandFns.php 90.71% <0%> (+0.71%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6983395...8e30660. Read the comment docs.

@ms609 ms609 merged commit 07112e2 into ms609:master Sep 10, 2018
@GlazerMann GlazerMann deleted the patch-21 branch September 11, 2018 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants