Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more generous with URL expansion #755

Merged
merged 13 commits into from
Sep 19, 2018
Merged

Be more generous with URL expansion #755

merged 13 commits into from
Sep 19, 2018

Conversation

GlazerMann
Copy link
Collaborator

@GlazerMann GlazerMann commented Sep 11, 2018

check for title and chapter

@codecov
Copy link

codecov bot commented Sep 11, 2018

Codecov Report

Merging #755 into master will decrease coverage by 1.77%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #755      +/-   ##
============================================
- Coverage     70.03%   68.25%   -1.78%     
+ Complexity     1634     1624      -10     
============================================
  Files            12       12              
  Lines          3310     3364      +54     
============================================
- Hits           2318     2296      -22     
- Misses          992     1068      +76
Impacted Files Coverage Δ Complexity Δ
Template.php 73.5% <100%> (-2.9%) 1442 <0> (-12)
apiFunctions.php 69.45% <0%> (-0.57%) 0% <0%> (ø)
DOItools.php 93.65% <0%> (-0.1%) 0% <0%> (ø)
gitpull.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
Page.php 75.57% <0%> (+0.92%) 73% <0%> (+2%) ⬆️
expandFns.php 90.97% <0%> (+0.97%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d41dadc...e5cac58. Read the comment docs.

ms609
ms609 previously requested changes Sep 19, 2018
Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the right place for this check. parsed_text should simply convert the text stored in the Template object to a string. Is there a reason not to include it in final_tidy?

@GlazerMann GlazerMann dismissed ms609’s stale review September 19, 2018 14:42

You were right, that was unneeded leftover code from testing. It works fine without it.

@ms609 ms609 merged commit 4cac27f into ms609:master Sep 19, 2018
@GlazerMann GlazerMann deleted the patch-2 branch September 19, 2018 21:33
@GlazerMann GlazerMann restored the patch-2 branch September 19, 2018 21:33
@GlazerMann GlazerMann deleted the patch-2 branch September 19, 2018 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants