-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be more generous with URL expansion #755
Conversation
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
============================================
- Coverage 70.03% 68.25% -1.78%
+ Complexity 1634 1624 -10
============================================
Files 12 12
Lines 3310 3364 +54
============================================
- Hits 2318 2296 -22
- Misses 992 1068 +76
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't the right place for this check. parsed_text
should simply convert the text stored in the Template object to a string. Is there a reason not to include it in final_tidy
?
You were right, that was unneeded leftover code from testing. It works fine without it.
check for title and chapter