Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop google.com from books #773

Merged
merged 6 commits into from
Sep 18, 2018
Merged

Drop google.com from books #773

merged 6 commits into from
Sep 18, 2018

Conversation

GlazerMann
Copy link
Collaborator

No description provided.

ms609
ms609 previously requested changes Sep 14, 2018
View reviewed changes
Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would a case-insensitive comparison be more inclusive, or is there something we might want to avoid?
This'd allow us to roll both checks into a single if(X && Y) statement.

@GlazerMann GlazerMann dismissed ms609’s stale review September 14, 2018 16:33

case-insensitive and one line done (test added too)

@ms609 ms609 merged commit 88e9dd2 into master Sep 18, 2018
@ms609 ms609 deleted the GlazerMann-patch-2 branch September 18, 2018 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ms609 ms609 ms609 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GlazerMann @ms609