[[file:img|12px|alt=words]] and such

[GlazerMann]

Current code does [[]] and [[|]].
Added up to this size:
[[File:Example.png|thumb|upright|alt=Example alt text|Example caption]]

[ms609]

Two thoughts:

(i): There's gotta be a better way! A recursive preg_replace, perhaps: while($text = preg_replace($START.$MID.$END)){} or something?

(ii): The test cases do not look like examples that would be encountered in the real world. Surely no-one should ever include an image in a title field. I don't think we need to worry about handling every garbage in, garbage out situation: if it's not a use case listed in the Citation template documentation, then it's the user's problem, not ours.

[josve05a]

It might be "garbage in", but it is valid garbage which renders properly. The bot currently makes it worse. And it is currently present on over 600 articles (insource:/title=[[([Ff]ile|[Ii]mage):/ -- note that a few are not cite templaes though)

[ms609]

By making it worse, the bot may help to draw attention to the incorrect information, increasing the chance that a human editor will step in and clean up the mess.

If it is a recurrent problem, then perhaps the cite templates can be modified to notice the bad input and notify users more prominently. That way users will gain immediate feedback and be able to change their behaviour, rather than the bot stepping in months later to make an edit that the original user may not see.

[josve05a]

If a "bodge" is incorrect but works, it should be "noted" with a CS1|2 error/maint. message rather than having the bot make the "bodge" both incorrect and not work. Rather have an error incorrect but "look nice" than incorrect and visually broken imo. There are more ways to draw attention to problems (such as maint. messages/categories/templates/etc.) than breaking a working template.

[GlazerMann]

The example is real-world.

[ms609]

Yes, I agree that a CS1/2 error message could be useful here, particularly given how widespread you have found the misuse to be!

[codecov]

Codecov Report

Merging #783 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##             master    #783      +/-   ##
===========================================
+ Coverage     70.15%   70.2%   +0.04%     
- Complexity     1649    1650       +1     
===========================================
  Files            12      12              
  Lines          3334    3339       +5     
===========================================
+ Hits           2339    2344       +5     
  Misses          995     995

Impacted Files	Coverage Δ	Complexity Δ
Template.php	76.49% <100%> (+0.05%)	1470 <0> (+1)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171a4c8...4fc77fc. Read the comment docs.

[GlazerMann]

@ms609 it is now done in a loop.

[ms609]

Much better, thanks!