-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update capitalization.php #858
Conversation
How about N.Y. and N.Y.C. as well? |
How about adding dots between all two- or three-letter combinations if they are to be capitalized? Such as BMC, AI, JAMA, NYT etc...I've seen a lot of weird Gigo, and it's better to keep status quo than a change from AI, JAMA, NYT, etc. to e.g. A.i, J.a.m.a, N.y.t. etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any A.B.C style acronyms where all the letters should NOT be capitalized? If so, then this is better addressed using a general rule in the capitalization function than manually entering all possible acronyms with and without dots. (And have you tested to see whether these are actually handled incorrectly in the present implementation?)
Ph.D. B.Sc. i.e. e.g. |
Codecov Report
@@ Coverage Diff @@
## master #858 +/- ##
============================================
+ Coverage 70.65% 75.48% +4.82%
- Complexity 1663 1792 +129
============================================
Files 13 13
Lines 3524 4107 +583
============================================
+ Hits 2490 3100 +610
+ Misses 1034 1007 -27
Continue to review full report at Codecov.
|
@ms609 I created an issue to keep this idea in our minds |
Ph.D, B.Sc both follow the rule "capitalize everything that comes after a full stop". i.e. and e.g. are perhaps unlikely phrases to appear in titles or journal names and might readily be accommodated by exceptions of their own if they do? |
🤔 Perhaps capitalize all acronyms and then do exceptions🤨 |
Will be handled elsewhere, if they require it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken out the dots as there is no evidence (yet) that they are needed; a suitable test should be added as part of the response to #860.
Well done for adding those tests, @GlazerMann !
Aus, British, Canadian
Those handy tests to the rescue again!
Washington DC. Which got me thinking so I added AC also. Current and the cooling. NASA added for good luck too. DC D.C. AC A.C. NASA