Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update capitalization.php #858

Merged
merged 11 commits into from
Sep 29, 2018
Merged

Update capitalization.php #858

merged 11 commits into from
Sep 29, 2018

Conversation

GlazerMann
Copy link
Collaborator

Washington DC. Which got me thinking so I added AC also. Current and the cooling. NASA added for good luck too. DC D.C. AC A.C. NASA

@josve05a
Copy link
Contributor

josve05a commented Sep 28, 2018

How about N.Y. and N.Y.C. as well?

@josve05a
Copy link
Contributor

josve05a commented Sep 28, 2018

How about adding dots between all two- or three-letter combinations if they are to be capitalized? Such as BMC, AI, JAMA, NYT etc...I've seen a lot of weird Gigo, and it's better to keep status quo than a change from AI, JAMA, NYT, etc. to e.g. A.i, J.a.m.a, N.y.t. etc.

Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any A.B.C style acronyms where all the letters should NOT be capitalized? If so, then this is better addressed using a general rule in the capitalization function than manually entering all possible acronyms with and without dots. (And have you tested to see whether these are actually handled incorrectly in the present implementation?)

@GlazerMann
Copy link
Collaborator Author

Ph.D. B.Sc. i.e. e.g.

@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #858 into master will increase coverage by 4.82%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #858      +/-   ##
============================================
+ Coverage     70.65%   75.48%   +4.82%     
- Complexity     1663     1792     +129     
============================================
  Files            13       13              
  Lines          3524     4107     +583     
============================================
+ Hits           2490     3100     +610     
+ Misses         1034     1007      -27
Impacted Files Coverage Δ Complexity Δ
Template.php 83.03% <0%> (+5.85%) 1608% <0%> (+129%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c391e0...af703d3. Read the comment docs.

@GlazerMann
Copy link
Collaborator Author

@ms609 I created an issue to keep this idea in our minds

@ms609
Copy link
Owner

ms609 commented Sep 28, 2018

Ph.D, B.Sc both follow the rule "capitalize everything that comes after a full stop". i.e. and e.g. are perhaps unlikely phrases to appear in titles or journal names and might readily be accommodated by exceptions of their own if they do?

@GlazerMann
Copy link
Collaborator Author

🤔 Perhaps capitalize all acronyms and then do exceptions🤨

@GlazerMann
Copy link
Collaborator Author

GlazerMann commented Sep 28, 2018

@ms609 can we accept this for now and the revisit with the ISSUE #860 I created. j.a.m.a. Does not become J.A.M.A.

Martin R. Smith added 2 commits September 29, 2018 07:39
Will be handled elsewhere, if they require it
Copy link
Owner

@ms609 ms609 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken out the dots as there is no evidence (yet) that they are needed; a suitable test should be added as part of the response to #860.

Martin R. Smith added 4 commits September 29, 2018 07:44
Well done for adding those tests, @GlazerMann !
Aus, British, Canadian
Those handy tests to the rescue again!
@ms609 ms609 merged commit 1c11fd1 into master Sep 29, 2018
@GlazerMann GlazerMann deleted the GlazerMann-patch-1 branch September 29, 2018 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants