Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aliases to arithmetic expressions #8

Merged
merged 3 commits into from
Oct 11, 2017

Conversation

ekmartin
Copy link
Contributor

I removed multispace matching from string_literal and integer_literal since it swallowed the whitespace needed in as_alias (and it also seemed reasonable to do this at a higher level than in the literal matchers itself, but let me know if you disagree).

It seemed like the only change needed to do so was to add whitespace matching to predicate instead, which it already had for some of the branches.

I'll send a separate PR to add alias support for literals as well.

@ms705
Copy link
Owner

ms705 commented Oct 11, 2017

LGTM 👍

@ms705 ms705 merged commit b612a33 into ms705:master Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants