fix: utils.isDate deprecated #1396
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
reviewed
Jun 12, 2024
wdavidw
force-pushed
the
fix/isdate-depracated
branch
from
1d0a038
to
ad21dd4
Compare
|
Thanks, I didn't saw that the function was moved. PR is updated to reflect your suggestion. |
|
Thanks, landed in 4f771c9. |
|
Thanks @mscdex for merging. Would you mind releasing a patch version as it currently blocks our test pipelines. |
|
Hi @mscdex, I don't want to be pushy but would have an anticipate date when the next release will be published ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js version 22 deprecated the
utils.isDatefunction. The proposal implements the proposed official correction present in the console outputUncaught DeprecationWarning: Theutil.isDateAPI is deprecated. Please usearg instanceof Dateinstead..Note, the deprecation brakes code execution when the
--throw-deprecationflag is enabled.