Skip to content

Commit 8d7f20f

Browse files
committed
[RT 62896] Log::Log4perl::Appender::ScreenColoredLevels now
inherits from Log::Log4perl::Appender::Screen and therefore supports the utf8 flag.
1 parent 0b3b61c commit 8d7f20f

File tree

2 files changed

+18
-10
lines changed

2 files changed

+18
-10
lines changed

Changes

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,11 @@
22
Revision history for Log::Log4perl
33
##################################################
44
1.32 (not yet released)
5-
* [RT 62674] Fixed call to deprecated form of UNIVERSAL::can (Karen
5+
* (ms) [RT 62674] Fixed call to deprecated form of UNIVERSAL::can (Karen
66
Etheridge).
7+
* (ms) [RT 62896] Log::Log4perl::Appender::ScreenColoredLevels now
8+
inherits from Log::Log4perl::Appender::Screen and therefore
9+
supports the utf8 flag.
710

811
1.31 (2010/10/27)
912
* (ms) Fixed the number of skipped tests for Windows for previous fix

lib/Log/Log4perl/Appender/ScreenColoredLevels.pm

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
##################################################
22
package Log::Log4perl::Appender::ScreenColoredLevels;
33
##################################################
4-
our @ISA = qw(Log::Log4perl::Appender);
4+
use Log::Log4perl::Appender::Screen;
5+
our @ISA = qw(Log::Log4perl::Appender::Screen);
56

67
use warnings;
78
use strict;
@@ -12,14 +13,18 @@ use Log::Log4perl::Level;
1213
##################################################
1314
sub new {
1415
##################################################
15-
my($class, @options) = @_;
16-
17-
my $self = {
18-
name => "unknown name",
19-
stderr => 1,
20-
color => {},
21-
@options,
22-
};
16+
my($class, %options) = @_;
17+
18+
my %specific_options = ( color => {} );
19+
20+
for my $option ( keys %specific_options ) {
21+
$specific_options{ $option } = delete $options{ $option } if
22+
exists $options{ $option };
23+
}
24+
25+
my $self = $class->SUPER::new( %options );
26+
@$self{ keys %specific_options } = values %specific_options;
27+
bless $self, __PACKAGE__; # rebless
2328

2429
# also accept lower/mixed case levels in config
2530
for my $level ( keys %{ $self->{color} } ) {

0 commit comments

Comments
 (0)