Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test failure due to quirk of unlink on Windows #100

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

itsuki-hayashi
Copy link
Contributor

@itsuki-hayashi itsuki-hayashi commented Jan 28, 2020

unlink on Windows does not delete the file instantly, and the Log4perl default to append, which cause the t/026FileApp.t to fail.

This fixes #77

@mohawk2
Copy link
Collaborator

mohawk2 commented Jul 21, 2020

Another approach that also works (before I checked to see if someone else had beaten me to it, well done) is to rename the file being used in the second test.

@mohawk2
Copy link
Collaborator

mohawk2 commented Jul 21, 2020

Thanks!

@mohawk2 mohawk2 merged commit 1c1f8fb into mschilli:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed test 'header_text'
2 participants