Add tests for override flag (PRC) #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests used ok(), but were manually checking expected and actual values. Since this is something done automatically by is(), which is already included by using Test::More, using is() is preferable.
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The override flag was not being tested in the smoke tests. This PR adds tests for setting explicitly to either a true or a false value.
Included in this pull request there is a commit that changes the tests using
ok()into tests usingis(). Since the tests were manually doing the check between expected and actual values, and sinceTest::Morewas already beingused, I thought this would be preferable.This PR is part of the Pull Request Challenge.