Add tests for override flag (PRC) #4

merged 2 commits into from Mar 30, 2017


None yet
2 participants

jjatria commented Mar 30, 2017

The override flag was not being tested in the smoke tests. This PR adds tests for setting explicitly to either a true or a false value.

Included in this pull request there is a commit that changes the tests using ok() into tests using is(). Since the tests were manually doing the check between expected and actual values, and since Test::More was already being used, I thought this would be preferable.

This PR is part of the Pull Request Challenge.

jjatria added some commits Mar 30, 2017

Use is() from Test::More instead of ok()
Tests used ok(), but were manually checking expected and actual values.
Since this is something done automatically by is(), which is already
included by using Test::More, using is() is preferable.

@mschout mschout merged commit decd07f into mschout:master Mar 30, 2017


This comment has been minimized.

Show comment
Hide comment

mschout Mar 30, 2017


Merged, thanks!


mschout commented Mar 30, 2017

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment