Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Migrate to Dagger #196

Closed
wants to merge 9 commits into from
Closed

[WIP] Migrate to Dagger #196

wants to merge 9 commits into from

Conversation

@msfjarvis
Copy link
Owner

msfjarvis commented Oct 30, 2019

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

Migrate from Koin to Dagger for Dependency Injection.

馃挕 Motivation and Context

Dagger provides compile time checking for dependencies compared to Koin's runtime approach.

馃挌 How did you test it?

Clean builds of the app succeed.

馃摑 Checklist

  • I ran ./gradlew spotlessApply before submitting the PR
  • I reviewed submitted code

馃敭 Next steps

Finish migrating remaining Koin users and remove all dependencies.

馃摳 Screenshots / GIFs

@msfjarvis msfjarvis force-pushed the msf/try-dagger-again branch 2 times, most recently from 68a4131 to 80b1639 Oct 30, 2019
@msfjarvis msfjarvis force-pushed the master branch from 41afd45 to aa54a65 Oct 31, 2019
@msfjarvis msfjarvis force-pushed the msf/try-dagger-again branch from 97f6663 to e555749 Oct 31, 2019
@msfjarvis msfjarvis force-pushed the master branch from aa54a65 to ceb5cf4 Oct 31, 2019
@msfjarvis msfjarvis force-pushed the msf/try-dagger-again branch from e555749 to cd00890 Nov 1, 2019
msfjarvis added 2 commits Oct 31, 2019
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
@msfjarvis msfjarvis force-pushed the msf/try-dagger-again branch from cd00890 to a57bd5f Nov 1, 2019
msfjarvis added 7 commits Nov 2, 2019
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
@msfjarvis

This comment has been minimized.

Copy link
Owner Author

msfjarvis commented Nov 24, 2019

I have discovered that I still despise Dagger.

@msfjarvis msfjarvis closed this Nov 24, 2019
@msfjarvis msfjarvis deleted the msf/try-dagger-again branch Nov 24, 2019
@msfjarvis msfjarvis restored the msf/try-dagger-again branch Dec 18, 2019
@msfjarvis msfjarvis deleted the msf/try-dagger-again branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.