This repository has been archived by the owner on Feb 11, 2020. It is now read-only.
[WIP] Migrate to Dagger #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfjarvis
force-pushed
the
msf/try-dagger-again
branch
2 times, most recently
from
68a4131
to
80b1639
Compare
msfjarvis
force-pushed
the
msf/try-dagger-again
branch
from
97f6663
to
e555749
Compare
msfjarvis
force-pushed
the
msf/try-dagger-again
branch
from
e555749
to
cd00890
Compare
added 2 commits
November 1, 2019 22:11
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
msfjarvis
force-pushed
the
msf/try-dagger-again
branch
from
cd00890
to
a57bd5f
Compare
added 7 commits
November 2, 2019 14:53
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
|
I have discovered that I still despise Dagger. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Migrate from Koin to Dagger for Dependency Injection.
💡 Motivation and Context
Dagger provides compile time checking for dependencies compared to Koin's runtime approach.
💚 How did you test it?
Clean builds of the app succeed.
📝 Checklist
./gradlew spotlessApplybefore submitting the PR🔮 Next steps
Finish migrating remaining Koin users and remove all dependencies.
📸 Screenshots / GIFs