-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum cmake version to 3.5 to avoid deprecation warning #1097
Conversation
753ed9c
to
faa8200
Compare
d289a35
to
df5726b
Compare
bcdc582
to
4e3ae6d
Compare
Thank you for sending the PR. So if you want to merge the PR before June 30th, 2024, you need to support 2.8.12. Something conditional branch in CMakeLists.txt is required. |
Aren't there two versions of cmake in centos? I think one is |
I could't find cmake3 package in CentOS7. |
Building msgpack gives currently gives the following warning: "CMake Deprecation Warning at CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED): Compatibility with CMake < 3.5 will be removed from a future version of CMake. Update the VERSION argument <min> value or use a ...<max> suffix to tell CMake that the project does not need compatibility with older versions." Reuse same solution as fc18087 as the policy CMP0060 introduced in cmake 3.3 causes problems with when linking for 32-bit otherwise.
4e3ae6d
to
8957d6e
Compare
Huh, I think I mixed it up with the cmake3 from the epel repo. My bad. I've added a conditional. Please take a look again. |
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## c_master #1097 +/- ##
=========================================
Coverage 55.45% 55.45%
=========================================
Files 8 8
Lines 1044 1044
=========================================
Hits 579 579
Misses 465 465 |
Thank you for updating! Looks good to me. |
Bump minimum cmake version to 3.5 to avoid deprecation warning
Building msgpack gives currently gives the following warning:
"CMake Deprecation Warning at CMakeLists.txt:1 (CMAKE_MINIMUM_REQUIRED):
Compatibility with CMake < 3.5 will be removed from a future version of
CMake.
Update the VERSION argument value or use a ... suffix to tell
CMake that the project does not need compatibility with older versions."
Reuse same solution as fc18087 as the
policy CMP0060 introduced in cmake 3.3 causes problems with when linking
for 32-bit otherwise.