Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added null pointer check. #59

Merged
merged 1 commit into from
Jan 28, 2014
Merged

Added null pointer check. #59

merged 1 commit into from
Jan 28, 2014

Conversation

redboltz
Copy link
Contributor

to fix issue#58

redboltz added a commit that referenced this pull request Jan 28, 2014
@redboltz
Merge pull request #59 from redboltz/add_null_check
9eb4583 
Added null pointer check.
@redboltz redboltz merged commit 9eb4583 into msgpack:master Jan 28, 2014
@redboltz redboltz mentioned this pull request Jan 28, 2014
Closed
@redboltz
Copy link
Contributor Author

redboltz commented Feb 3, 2014

I misunderstood the original code. These kinds of redundant checking should be removed so I created a new pull request #62

Or Is this just for the safety sake?
No, it was just my error. AFAIK, the msgpack-c maintainers including me always try to keep our code simple:)

@redboltz redboltz deleted the add_null_check branch March 31, 2014 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redboltz @kzk