Skip to content

Commit bed120e

Browse files
authored
Merge pull request #49 from msgpack/fix_tests
fix tests on Edge for ReadableStream
2 parents 7513075 + c422db6 commit bed120e

File tree

4 files changed

+17
-5
lines changed

4 files changed

+17
-5
lines changed

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ script: |
4242
if [ "${BROWSER}" = "" ]
4343
then npm run test:cover
4444
else
45-
travis_wait 300 npm run test:browser -- --browsers "$BROWSER"
45+
travis_wait 600 npm run test:browser -- --browsers "$BROWSER"
4646
fi
4747
after_success: |
4848
if [ "${BROWSER}" = "" ]
49-
then nyc report --reporter=json > coverage/coverage.json && codecov
49+
then codecov -f coverage/*.json
5050
fi

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"test:cover:wasm": "npx nyc --no-clean npm run test:wasm",
2323
"test:cover:td": "npx nyc --no-clean npm run test:td",
2424
"cover:clean": "rimraf .nyc_output coverage/",
25-
"cover:report": "nyc report --reporter=lcov --reporter=text-summary --reporter=html",
25+
"cover:report": "nyc report --reporter=text-summary --reporter=html --reporter=json",
2626
"test:browser": "karma start --single-run",
2727
"test:browser:firefox": "karma start --single-run --browsers FirefoxHeadless",
2828
"test:browser:chrome": "karma start --single-run --browsers ChromeHeadless",

sauceLabs.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,6 @@ export const sauceLaunchers: Record<string, SauceLauncher> = {
7777
browserName: "Chrome",
7878
platformName: "Android",
7979
platformVersion: "latest",
80-
deviceName: "Android GoogleAPI Emulator",
80+
deviceName: "Android Emulator",
8181
},
8282
};

test/whatwg-streams.test.ts

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,21 @@
11
import { deepStrictEqual } from "assert";
22
import { decodeAsync, encode, decodeArrayStream } from "@msgpack/msgpack";
33

4+
const isReadableStreamConstructorAvailable: boolean = (() => {
5+
try {
6+
// Edge <= 18 has ReadableStream but its constructor is not available
7+
new ReadableStream({
8+
start() {},
9+
});
10+
return true;
11+
} catch {
12+
return false;
13+
}
14+
})();
15+
416
describe("whatwg streams", () => {
517
before(function() {
6-
if (typeof ReadableStream === "undefined") {
18+
if (!isReadableStreamConstructorAvailable) {
719
this.skip();
820
}
921
});

0 commit comments

Comments
 (0)