Zero-out msgpack_buffer_chunk_t after allocation #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: msgpack#341 These struct contain a VALUE reference so if we don't zero it out, it could be pointing at a T_NONE or some other old object slot. Especially since we can re-use existing chunks.
peterzhu2118
approved these changes
Jun 29, 2023
casperisfine
pushed a commit
to Shopify/msgpack-ruby
that referenced
this pull request
Jul 12, 2023
Fix: msgpack#342 Reseting the memory in _msgpack_buffer_alloc_new_chunk was pointless because the previous `tail` is immediately copied into it, and it's the `tail` that is then used by the caller. So it's the `tail` we should zero-out.
casperisfine
pushed a commit
to Shopify/msgpack-ruby
that referenced
this pull request
Jul 12, 2023
Fix: msgpack#342 Reseting the memory in _msgpack_buffer_alloc_new_chunk was pointless because the previous `tail` is immediately copied into it, and it's the `tail` that is then used by the caller. So it's the `tail` we should zero-out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #341
These struct contain a VALUE reference so if we don't zero it out, it could be pointing at a T_NONE or some other old object slot.
Especially since we can re-use existing chunks.
cc @peterzhu2118 @pavel-workato