Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to click>=7.0.0 #87

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Conversation

no-preserve-root
Copy link
Contributor

Click has changed the selection for parameter names (i.e., the shell-parameter-to-python parameter mapping) to select the longest option name first:

The naming rules can be found in :ref:`parameter_names`. In short, you
can refer the option **implicitly** by the longest dash-prefixed argument:

This needs to be reflected in run(); the code will no longer work with click <7.0.0, unfortunately.

@msiemens msiemens merged commit 86b30b1 into msiemens:master Dec 11, 2018
@msiemens
Copy link
Owner

Thanks for your contribution! ❤️

@msiemens
Copy link
Owner

I'll try to publish a new release of PyGitUp in the next few days or next week 🙃

@msiemens
Copy link
Owner

PyGitUp v1.6.1 now includes this change 🙂

@no-preserve-root
Copy link
Contributor Author

Sorry to nag you about that, but would you mind a) tagging the revision and b) perhaps fixing my name in the changelog?

@msiemens
Copy link
Owner

Oh, sorry for not mentioning you correctly in the release notes! And I've also tagged the version now correctly. Sorry for mixing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants