-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 0 capacity issue. now cache_size can be 0 #187
Conversation
@msiemens Do you know why the test-build with Python 2.6 failed? |
Actually, I'm just thinking about if the best way to disable the query cache would be to actually use a |
@msiemens Yes, I think you are right. Defining a cache_size of zero, fullfills the purpose. Another option is not necessary. |
This is now released in v3.8.0 🙂 |
@msiemens CRITICAL:pip.index:Could not find a version that satisfies the requirement tinydb==3.8.0 (from versions: 1.0.0, 1.0.1, 1.1.0, 1.1.1, 1.2.0, 1.3.0, 1.4.0, 2.0.0, 2.0.1, 2.1.0, 2.2.0, 2.2.1, 2.2.2, 2.3.0b0, 2.3.1, 2.3.1.post1, 2.3.1.post2, 2.3.2, 2.4, 3.0.0, 3.1.0, 3.1.1, 3.1.2, 3.1.3, 3.2.0, 3.2.1, 3.2.2, 3.2.3, 3.3.0, 3.3.1, 3.4.0, 3.4.1, 3.5.0, 3.6.0, 3.7.0) |
Whoops! Forgot to publish it on PyPI, sorry! Should work now 🙂 |
thanks! 👍 I'm on 3.8.0 😄 |
I encountered a problem while setting cache_size to 0. The result was an unlimited cache because in python "0" evaluates to false. This PR would fix this.
kind regards