New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data-binding #8

Open

andreas-mausch opened this issue Nov 3, 2018 · 5 comments

Contributor

andreas-mausch commented Nov 3, 2018

Do you plan to support some kind of data-binding?

I think of it in a way that you pass a model object (Observable?) to a TextField, and each time the string is changed, the UI is changed as well.

And, additionally, each time the user types into the TextField, the model object get's changed automatically.

Owner

msink commented Nov 3, 2018

As general direction - yes, it should support some data-binding, but I think it should be separate library.

No concrete plans for now.

Contributor

mervyn-mccreight commented Nov 4, 2018

Hello,

we (@andreas-mausch and me) would like to work on it. We already have a prototype version of this running (included in the DSL, not a separate library), but we are not sure how to test it. We found some files in the test directory, but can not make any sense of them. How can we write unit-tests for the stuff we came up with?

Our prototype is implementing the same as you can see in this vueJS example here: https://vuejs.org/v2/guide/#Handling-User-Input (app-6) -- the one with the input and the text.

mervyn-mccreight added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          Give components the ability to react on value changes through listeners

2b8952c

Introduce an Observable to give anything that extends it the ability to
attach and call listeners that communicate a value change passing the new
value.

Refer to issue: msink#8


Co-authored-by: Andreas Mausch <andreas.mausch@gmail.com>

mervyn-mccreight added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          Give components the ability to react on value changes through listeners

4a428f0

Introduce an Observable to give anything that extends it the ability to
attach and call listeners that communicate a value change passing the new
value.

Refer to issue: msink#8


Co-authored-by: Andreas Mausch <andreas.mausch@gmail.com>

mervyn-mccreight added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          Make values accessible and changeable through ui component borders

d58a4e1

Refer to issue: msink#8


Co-authored-by: Andreas Mausch <andreas.mausch@gmail.com>

mervyn-mccreight added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          Enable data binding for textfield and label ui components

10db0cb

Add possibility to do data binding to label and textfield and introduce a
simple example in the samples, to showcase a shared string value between an
input and a label.

Refer to issue: msink#8


Co-authored-by: Andreas Mausch <andreas.mausch@gmail.com>

andreas-mausch added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          Make TextField and Label to *always* have a ModelEntry

8091bdc

Refer to issue: msink#8


Co-authored-by: Mervyn McCreight <mervyn.mccreight@gmail.com>

andreas-mausch added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          Two versions to create a label: Either with a static text, or a model

a30ba27

Don't let users be confused by the optional parameters in the DSL.
Now we provide two versions which force you to set the correct parameters.

Refer to issue: msink#8


Co-authored-by: Mervyn McCreight <mervyn.mccreight@gmail.com>

andreas-mausch added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          Inline TextField.addOnChangeListener()

24f23c2

Refer to issue: msink#8


Co-authored-by: Mervyn McCreight <mervyn.mccreight@gmail.com>

Owner

msink commented Nov 5, 2018

About tests - test directory was here from very early days of development, and still not used.
Maybe it should be removed or cleaned - I still don't figure out how to test this correctly.

Anyway it too should wait for migration to 'multiplatform' plugin.

andreas-mausch added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          Use a sensible default value for textfield.modelEntry

b06d69b

Refer to issue: msink#8

Co-authored-by: Mervyn McCreight <mervyn.mccreight@gmail.com>

andreas-mausch added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          Force model use for password- and search-fields

521f1ef

* For the DSL, the model is still optional
* New sample data-binding-2, which features all new model-using widgets

Refer to issue: msink#8

Co-authored-by: Mervyn McCreight <mervyn.mccreight@gmail.com>

andreas-mausch added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          Show values of data-bound models in data-binding-2 sample

b08cd35

Refer to issue: msink#8

Co-authored-by: Mervyn McCreight <mervyn.mccreight@gmail.com>

andreas-mausch added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          ModelEntry for TextArea

cd49b05

Refer to issue: msink#8

Co-authored-by: Mervyn McCreight <mervyn.mccreight@gmail.com>

andreas-mausch added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          Fix build after merge

ebff52a

Refer to issue: msink#8

Co-authored-by: Mervyn McCreight <mervyn.mccreight@gmail.com>

andreas-mausch added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          Refactoring: remove unnecessary parentheses

34e3921

Refer to issue: msink#8

Co-authored-by: Mervyn McCreight <mervyn.mccreight@gmail.com>

andreas-mausch added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          Privatize modelEntry

05d1506

Refer to issue: msink#8

Co-authored-by: Mervyn McCreight <mervyn.mccreight@gmail.com>

andreas-mausch added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          ModelEntry for Checkbox

f1e102d

Refer to issue: msink#8

Co-authored-by: Mervyn McCreight <mervyn.mccreight@gmail.com>

andreas-mausch added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          Refactoring: Label

253c90b

Refer to issue: msink#8

Co-authored-by: Mervyn McCreight <mervyn.mccreight@gmail.com>

andreas-mausch added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          First version of a model for the combobox

aa28b4b

* Provide a list of values and a ModelEntry for the selected element
* When a different item is selected, the model is updated accordingly
* Values can be list of a user-defined type, the text displayed is the toString()
* Changes to the values are not reflected yet (WIP)

Refer to issue: msink#8

Co-authored-by: Mervyn McCreight <mervyn.mccreight@gmail.com>

andreas-mausch added a commit to mervyn-mccreight/kotlin-libui that referenced this issue


          Add Todo for nulls in ModelEntry

9aded09

Refer to issue: msink#8

Co-authored-by: Mervyn McCreight <mervyn.mccreight@gmail.com>

Contributor Author

andreas-mausch commented Nov 27, 2018

@msink Can you take a look at the changes in this branch and tell us if you like it? https://github.com/mervyn-mccreight/kotlin-libui/tree/data-binding

Just check the new examples data-binding-1 and 2 to get an impression.

It's not complete yet, and we want to rename "ModelEntry" to "Property" to be more similar to TornadoFX.
But if you in general like what we did, I would continue on implementing ObservableLists for ComboBoxes and ListViews.

Owner

msink commented Nov 27, 2018 •

edited

Loading

I'm not competent in this area, but to me it looks overcomplicated.
Can it be just some data class, something like is done for tables?
checkbox(Data::checkbox)

Maybe more clean way could be using coroutines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment