Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L8150: display panel support #19

Merged
merged 9 commits into from Aug 11, 2019

Conversation

@TravMurav
Copy link

commented Aug 6, 2019

No description provided.

@TravMurav TravMurav changed the title L8150: display panelq support L8150: display panel support Aug 6, 2019

@Minecrell
Copy link
Member

left a comment

Please squash my two commits into one

arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts Outdated Show resolved Hide resolved
drivers/gpu/drm/msm/dsi/phy/dsi_phy.c Outdated Show resolved Hide resolved
arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts Outdated Show resolved Hide resolved

@TravMurav TravMurav force-pushed the l8150-display branch from 343e630 to 8be8332 Aug 10, 2019

@Minecrell
Copy link
Member

left a comment

Thanks for making the changes! Two more minor comments. Also:

Can you rebase your branch on top of master? Then make an additional commit that changes arch/arm64/configs/msm8916_defconfig and adds your panel config option as =m (just edit it with a text editor for now, ...).

This will enable Drone CI, which automatically builds your PR to see if it compiles fine. It will also check your commits for major style problems. :)

arch/arm64/boot/dts/qcom/msm8916-longcheer-l8150.dts Outdated Show resolved Hide resolved
drivers/gpu/drm/panel/panel-booyi-otm1287.c Outdated Show resolved Hide resolved

@TravMurav TravMurav force-pushed the l8150-display branch from 8be8332 to 904a415 Aug 11, 2019

@Minecrell
Copy link
Member

left a comment

So Drone CI runs scripts/checkpatch.pl for you now. You can see the results here: https://cloud.drone.io/msm8916-mainline/linux/29/1/3

The build is marked as failed if checkpatch reports an ERROR:. Warnings/checks are ignored. This is because it makes sense to ignore certain checkpatch warnings, if that makes the code more readable. (Also see Submitting patches - Style check your changes)

Your patches look very good, I'd just fix this minor thing in the panel driver.

drivers/leds/leds-qcom-lpg.c Outdated Show resolved Hide resolved

andersson and others added some commits Nov 15, 2017

leds: Add driver for Qualcomm LPG
The Light Pulse Generator (LPG) is a PWM-block found in a wide range of
PMICs from Qualcomm. It can operate on fixed parameters or based on a
lookup-table, altering the duty cycle over time - which provides the
means for e.g. hardware assisted transitions of LED brightness.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
DT: leds: Add Qualcomm Light Pulse Generator binding
This adds the binding document describing the three hardware blocks
related to the Light Pulse Generator found in a wide range of Qualcomm
PMICs.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Acked-by: Rob Herring <robh@kernel.org>

@TravMurav TravMurav force-pushed the l8150-display branch from 904a415 to dcc8cda Aug 11, 2019

@TravMurav TravMurav merged commit dcc8cda into master Aug 11, 2019

2 checks passed

continuous-integration/drone/pr Build is passing
Details
continuous-integration/drone/push Build is passing
Details

@Minecrell Minecrell deleted the l8150-display branch Aug 11, 2019

Minecrell pushed a commit that referenced this pull request Aug 12, 2019

loop: set PF_MEMALLOC_NOIO for the worker thread
A deadlock with this stacktrace was observed.

The loop thread does a GFP_KERNEL allocation, it calls into dm-bufio
shrinker and the shrinker depends on I/O completion in the dm-bufio
subsystem.

In order to fix the deadlock (and other similar ones), we set the flag
PF_MEMALLOC_NOIO at loop thread entry.

PID: 474    TASK: ffff8813e11f4600  CPU: 10  COMMAND: "kswapd0"
   #0 [ffff8813dedfb938] __schedule at ffffffff8173f405
   #1 [ffff8813dedfb990] schedule at ffffffff8173fa27
   #2 [ffff8813dedfb9b0] schedule_timeout at ffffffff81742fec
   #3 [ffff8813dedfba60] io_schedule_timeout at ffffffff8173f186
   #4 [ffff8813dedfbaa0] bit_wait_io at ffffffff8174034f
   #5 [ffff8813dedfbac0] __wait_on_bit at ffffffff8173fec8
   #6 [ffff8813dedfbb10] out_of_line_wait_on_bit at ffffffff8173ff81
   #7 [ffff8813dedfbb90] __make_buffer_clean at ffffffffa038736f [dm_bufio]
   #8 [ffff8813dedfbbb0] __try_evict_buffer at ffffffffa0387bb8 [dm_bufio]
   #9 [ffff8813dedfbbd0] dm_bufio_shrink_scan at ffffffffa0387cc3 [dm_bufio]
  #10 [ffff8813dedfbc40] shrink_slab at ffffffff811a87ce
  #11 [ffff8813dedfbd30] shrink_zone at ffffffff811ad778
  #12 [ffff8813dedfbdc0] kswapd at ffffffff811ae92f
  #13 [ffff8813dedfbec0] kthread at ffffffff810a8428
  #14 [ffff8813dedfbf50] ret_from_fork at ffffffff81745242

  PID: 14127  TASK: ffff881455749c00  CPU: 11  COMMAND: "loop1"
   #0 [ffff88272f5af228] __schedule at ffffffff8173f405
   #1 [ffff88272f5af280] schedule at ffffffff8173fa27
   #2 [ffff88272f5af2a0] schedule_preempt_disabled at ffffffff8173fd5e
   #3 [ffff88272f5af2b0] __mutex_lock_slowpath at ffffffff81741fb5
   #4 [ffff88272f5af330] mutex_lock at ffffffff81742133
   #5 [ffff88272f5af350] dm_bufio_shrink_count at ffffffffa03865f9 [dm_bufio]
   #6 [ffff88272f5af380] shrink_slab at ffffffff811a86bd
   #7 [ffff88272f5af470] shrink_zone at ffffffff811ad778
   #8 [ffff88272f5af500] do_try_to_free_pages at ffffffff811adb34
   #9 [ffff88272f5af590] try_to_free_pages at ffffffff811adef8
  #10 [ffff88272f5af610] __alloc_pages_nodemask at ffffffff811a09c3
  #11 [ffff88272f5af710] alloc_pages_current at ffffffff811e8b71
  #12 [ffff88272f5af760] new_slab at ffffffff811f4523
  #13 [ffff88272f5af7b0] __slab_alloc at ffffffff8173a1b5
  #14 [ffff88272f5af880] kmem_cache_alloc at ffffffff811f484b
  #15 [ffff88272f5af8d0] do_blockdev_direct_IO at ffffffff812535b3
  #16 [ffff88272f5afb00] __blockdev_direct_IO at ffffffff81255dc3
  #17 [ffff88272f5afb30] xfs_vm_direct_IO at ffffffffa01fe3fc [xfs]
  #18 [ffff88272f5afb90] generic_file_read_iter at ffffffff81198994
  #19 [ffff88272f5afc50] __dta_xfs_file_read_iter_2398 at ffffffffa020c970 [xfs]
  #20 [ffff88272f5afcc0] lo_rw_aio at ffffffffa0377042 [loop]
  #21 [ffff88272f5afd70] loop_queue_work at ffffffffa0377c3b [loop]
  #22 [ffff88272f5afe60] kthread_worker_fn at ffffffff810a8a0c
  #23 [ffff88272f5afec0] kthread at ffffffff810a8428
  #24 [ffff88272f5aff50] ret_from_fork at ffffffff81745242

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.