-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix https://github.com/msoucy/dproto/issues/115 #116
Conversation
Changes Unknown when pulling 69776bd on timotheecour:fix_115_overflow into ** on msoucy:master**. |
@msoucy I just added a unittest; it shows additional bugs for types: |
Changes Unknown when pulling c7209fd on timotheecour:fix_115_overflow into ** on msoucy:master**. |
Changes Unknown when pulling 909454f on timotheecour:fix_115_overflow into ** on msoucy:master**. |
@msoucy |
I'm never sure which versions of dmd to with Travis... It's too bad that there isn't a way to specify "the versions that are available to the package managers for commonly used distros". I'll make that update to Though I haven't been following this as strictly as I should have, I would prefer that dproto is usable on all compilers that are installable by default on Fedora and Debian. |
See #116 (comment) for more details
any comments on this PR? |
PR #123 fixes all Travis failures. After merging this PR should be green, too. |
Changes Unknown when pulling c6a5641 on timotheecour:fix_115_overflow into ** on msoucy:master**. |
Changes Unknown when pulling 5bf0a18 on timotheecour:fix_115_overflow into ** on msoucy:master**. |
@timotheecour Please have a look at #130. I think you can fix your PR with code from mine. |
done, closing in favor of #131 |
this should fix #115.
side question for @msoucy:
please see comment in diff:
should i use
readVarint!(Unsigned!T2)()
instead ofsrc.readVarint()
instatic if(T == "sint32" || T == "sint64")
block?currently, it'll force to use ulong and then call
fromZigZag().to!T2();
(ie convert to a int or long)with the code in comment, it'll read into a uint or ulong, then call zigzag to convert to int or long.