Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RBAC fix, doc consistency, minor improvements. #311

Merged
merged 36 commits into from
May 2, 2022
Merged

RBAC fix, doc consistency, minor improvements. #311

merged 36 commits into from
May 2, 2022

Conversation

ulkeba
Copy link
Contributor

@ulkeba ulkeba commented May 2, 2022

No description provided.

ulkeba and others added 21 commits April 27, 2022 11:18
@ulkeba
Allow communication with API server via udp/1194.
c53b2e8 
References:
mspnp#223
https://docs.microsoft.com/en-us/azure/firewall/protect-azure-kubernetes-service
@ulkeba
Return IP address instead of res. ID (acc to doc)
1a1562f
@ulkeba
Minimal user feedback: echo variables to console.
391a5e9
@ulkeba
ifconfig.io to return IPv4 addr for access policy
cdfa294
@ulkeba
Notes for macOS users, having BSD sed.
637567c
@ulkeba @ckittel
Improvement to comment.
5849c9d 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@ulkeba
Comment out firewall rule, but add hints.
2f2b4fc
@ulkeba
Enable FW rule in bicep; remove warning.
595e634
@ulkeba
Merge branch 'mspnp:main' into main
a124509
@ulkeba
Update references to 'aks-baseline'.
0031166
@ulkeba
Get current branch name and pass as parameter.
5138d15
@ulkeba
Pass domain name as parameter to curl container.
9d10690
@ulkeba
Optimize docs for pre-existing AAD group.
2e1e913 
- Add bash snippet to set pre-existing group.
- Add hints to skip user creation / member adding group has members.
@ulkeba
Hint for single-tenant deployment.
6dcfb06
@ulkeba
Make namespace reader group optional.
6c76074
@ulkeba
Fix: Print correct variable name.
379460e
@ulkeba
Only stage intentionally changed file for commit.
fba516b
@ulkeba
FIx deployment failures on role lookup
9234b57
@ulkeba
Add some clarification to docs.
8705e9e
@ulkeba
Make saveenv.sh independent of current directory.
e5ef48a
@ulkeba
Append suffix to GITOPS variables...
25d2365 
...making sure they are also written to aks_baseline.env by saveenv.sh.
ckittel
ckittel requested changes May 2, 2022
View reviewed changes
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, nice set of quality of life improvements! Thanks! Please see the suggestions here.

01-prerequisites.md Outdated Show resolved Hide resolved
03-aad.md Outdated Show resolved Hide resolved
03-aad.md Outdated Show resolved Hide resolved
03-aad.md Outdated Show resolved Hide resolved
03-aad.md Show resolved Hide resolved
10-workload.md Show resolved Hide resolved
11-validation.md Outdated Show resolved Hide resolved
11-validation.md Show resolved Hide resolved
cluster-stamp.bicep Outdated Show resolved Hide resolved
saveenv.sh Show resolved Hide resolved
@ckittel ckittel added documentation Improvements or additions to documentation enhancement New feature or request labels May 2, 2022
@ckittel ckittel self-assigned this May 2, 2022
ulkeba and others added 10 commits May 2, 2022 21:41
@ulkeba @ckittel
Update 01-prerequisites.md
27164ef 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@ulkeba @ckittel
Update 03-aad.md
9aac22e 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@ulkeba @ckittel
Update 03-aad.md
ada0835 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@ulkeba @ckittel
Update 03-aad.md
f428e81 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@ulkeba @ckittel
Update 03-aad.md
0a0125f 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@ulkeba @ckittel
Update 11-validation.md
04bae04 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@ulkeba @ckittel
Update 03-aad.md
cbf6c2d 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@ulkeba @ckittel
Update 03-aad.md
881640b 
Co-authored-by: Chad Kittel <chad.kittel@gmail.com>
@ulkeba
GITOPS variables are just 'local'.
2563ded
@ulkeba
Merge remote-tracking branch 'fork/main' into main
9aa9eab
ckittel
ckittel approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@ckittel ckittel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, time to :shipit:.

@ckittel ckittel merged commit 1195284 into mspnp:main May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckittel ckittel ckittel approved these changes

Assignees

@ckittel ckittel

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulkeba @ckittel