WIP

msridhar · Jan 22, 2023 · 7c8ac63 · 7c8ac63
1 parent c4c7c4b
commit 7c8ac63
Show file tree

Hide file tree

Showing 28 changed files with 2,324 additions and 1,161 deletions.
diff --git a/build.gradle b/build.gradle
@@ -62,7 +62,7 @@ subprojects { project ->
                     "-Xlint:deprecation",
                     "-Xlint:rawtypes",
                     "-Xlint:unchecked",
-                    "-Werror"
+                    //"-Werror"
             ]
             options.errorprone {
                 // disable warnings in generated code; AutoValue code fails UnnecessaryParentheses check

diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
@@ -62,6 +62,7 @@ def apt = [
     autoServiceAnnot : "com.google.auto.service:auto-service-annotations:${versions.autoService}",
     jakartaInject    : "jakarta.inject:jakarta.inject-api:2.0.0",
     javaxInject      : "javax.inject:javax.inject:1",
+    errorProneSupport: "tech.picnic.error-prone-support:error-prone-contrib:0.7.0"
 ]
 
 def build = [

diff --git a/nullaway/build.gradle b/nullaway/build.gradle
@@ -30,6 +30,7 @@ dependencies {
     annotationProcessor deps.apt.autoValue
     compileOnly deps.apt.autoServiceAnnot
     annotationProcessor deps.apt.autoService
+    errorprone deps.apt.errorProneSupport
     compileOnly deps.build.jsr305Annotations
     compileOnly deps.test.jetbrainsAnnotations
 
@@ -38,6 +39,8 @@ dependencies {
     implementation deps.build.checkerDataflow
     implementation deps.build.guava
 
+    //testAnnotationProcessor deps.apt.errorProneSupport
+
     testImplementation project(":annotations")
     testImplementation deps.test.junit4
     testImplementation(deps.build.errorProneTestHelpers) {
@@ -69,6 +72,16 @@ dependencies {
     nullawayJar "com.uber.nullaway:nullaway:$VERSION_NAME"
 }
 
+tasks.withType(JavaCompile) {
+    options.errorprone {
+        check("StaticImport", CheckSeverity.OFF)
+        check("CanonicalAnnotationSyntax", CheckSeverity.OFF)
+        check("FormatStringConcatenation", CheckSeverity.OFF)
+        check("CollectorMutability", CheckSeverity.OFF)
+        check("IdentityConversion", CheckSeverity.OFF)
+        errorproneArgs.addAll("-XepPatchChecks:ErrorProneTestHelperSourceFormat", "-XepPatchLocation:IN_PLACE")
+    }
+}
 javadoc {
     failOnError = false
 }