Meta vaults cannot re-add underlying vaults after removal #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I found a similar issue on another vault .Good catch |
doncesarts
approved these changes
Dec 8, 2022
tushargargght
force-pushed
the
220_macro_issue_reAddVault
branch
from
270a055
to
0f11637
Compare
Merged
naddison36
added a commit
that referenced
this pull request
Jan 10, 2023
* fix: npm publish action (#86) * chore: adds publish web to publish action * feat: fraxBP vaults (#71) * feat: test for update assetsPerShare after removal of underlyingVault * feat: ConvexFrax based vaults * chore: Refactor Curve lib tests (#74) * chore: using Hardhat network helpers for setBalance, setStorageAt and stopImpersonateAccount (#82) * fix: missing awaits in savePlus fork tests * refact: reduce gas consumption while donating tokens (#87) * chore: updated docs for second audit * chore: adds deployment address (#93) * fix: removeVault() will block because of incorrect vaults length (#96) * fix: modified require to use total vaults length instead of active vaults * feat: test for nth vault removal * fix: outdated assets amount in _redeem and _mint for PeriodicAllocationAbstractVault (#99) * feat: recalculate assets amount of successful assetsPerShare update * feat: tests for recalculating assetsPerShare for redeem and mint * fix: Meta vaults cannot re-add underlying vaults after removal (#100) * feat: removed allowance in remove vault * fix: test for remove and re-add vault * fix: liq-donate-tokens task with multiple rewards (#101) * fix: liq-settle-swap task (#103) * fix: removes death code from LiquidatorVaults (#104) * fix: RoundUp for `mint`, `previewMint`, `withdraw` and `previewWithdraw` (#102) * feat: contract changes for roundUp * feat: LightBasicVault roundUp * feat: roundUp unit-tests * feat: 3Crv based vault changes * feat: FraxBp based vault changes * feat: roundUp tests and scaling bug fix * fix: reset network before running test * fix: [Macro] Medium and lower criticality fixes (#106) * feat: [M-4] added check for performance fees too high during initialization * feat: [L-2] cannot remove cached vault * feat: [Q-1] removed zero-address check for code consistency * feat: [Q-2] removed unused imports * feat: [Q-3] corrected comment * feat: [G-1] No check if performanceFee is 0 * feat: [G-3] Unnecessary control variable initialization of for loops And removed zero address check vaultManagerRole * fix: fork-tests for sameAssetsUnderlyingVaults behavior for removeVault * feat: [G-2] uint24 for performanceFee * fix: uint24 performanceFee * fix: unit-test errors * fix: removed toNumber() * chore: toNumber fix * fix: minor fixes * feat: updated diagrams * feat: get historical token balances using token-balance HH task (#107) * fix: liquidator retry approvals (#110) * fix: liquidator retry approvals by pre-approving the async swapper to transfer reward tokens * fix: typos in README (#112) Co-authored-by: doncesarts <doncesarts@gmail.com> Co-authored-by: tushargargght <tushargargght@gmail.com> Co-authored-by: omahs <73983677+omahs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the bug
In
SameAssetUnderlyingsAbstractVault.solassets are approved to the max uint256 amount usingSafeERC20.safeApprove. According to the documentation within SafeERC20.sol:If the vault manager removes an underlying vault and tries to re-add it, the transaction will revert.
Fix
When removing a vault, resetting the allowance to 0