test: increase test coverage on Liquidator #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ults into issue/test-coverage
naddison36
force-pushed
the
issue/test-coverage
branch
from
dc263f8
to
a8b6cd2
Compare
naddison36
approved these changes
Nov 21, 2022
| @@ -27,7 +27,7 @@ struct Liquidation { | |||
| * @dev VERSION: 1.0 | |||
| * DATE: 2022-05-11 | |||
| */ | |||
| contract Liquidator is Initializable, ImmutableModule, InitializableReentrancyGuard { | |||
| contract Liquidator is Initializable, ImmutableModule, InitializableReentrancyGuard, ILiquidatorV2 { | |||
| @@ -776,6 +776,9 @@ abstract contract Curve3CrvAbstractMetaVault is AbstractSlippage, LightAbstractV | |||
| /// @dev Approves Curve's 3Pool contract to transfer assets (DAI, USDC or USDT) from this vault. | |||
| /// Also approves the underlying Meta Vault to transfer 3Crv from this vault. | |||
| function _resetAllowances() internal { | |||
| _asset.safeApprove(address(Curve3PoolCalculatorLibrary.THREE_POOL), 0); | |||
naddison36
added a commit
that referenced
this pull request
Nov 21, 2022
* feat: Added afterRemoveVault hook and updateAssestsPerShare after vault is removed * feat: test for update assetsPerShare after removal of underlyingVault * Hardhat tasks to snap vault data (#72) * chore: small update to vault deposit and mint HH tasks * chore: removed links to missing FraxBP diagrams * feat: added convex-3crv-snap HH task chore: added assets in underlying vaults to convex-3crv-mv-snap HH task * chore: test to get data for a worked sandwich attack on a Convex 3Crv vault * chore: added collected fees to vault snaps * chore: added worked Curve Metapools example for article * Docs and fork tests (#73) * chore: added process diagram for chargePerformanceFee * chore: README updated * chore: fork test donation of USDT and DAI * chore: Added maxFee protection to liq-init-swap HH task chore: better reporting of rewards in liq-collect-rewards HH task * chore: add gas price to liq-init-swap HH task * chore: HH task liq-donate-tokens further parameterized * Fix to charge performance fee (#75) * chore: Updated HH task convex-3crv-snap * chore: added stored assets/share to convex-3crv-mv-snap HH task fix: logs in mv-charge-perf-fee HH task * fix: charge of performance fee needs to store assets per share with fee shares included * chore: updated PerfFeeAbstractVault version * chore: added docgen script using solidity-docgen * chore: Added HH task vault-max-withdraw * feat: Added HH task vault-slippage to measure deposit and redeem slippage * chore: README updated with docgen * chore: creates npm publish action (#78) * chore: creates npm publish action * chore: adds comments to npmrc * chore: updates github actions to do not run when draft * chore: updates github actions to do not run when draft * chore: updates publish config on web-config.ts * test: increase test coverage on Liquidator (#79) * test: increse test coverage on Liquidator * chore: simplified Curve library tests (#81) * fix: to Curve3CrvAbstractMetaVault reset allowance * test: increase test coverage on libraries * chore: added updateAssetPerShare and chargePerformanceFee to fork tests * chore: removed modules not used by metavaults * chore: increased coverage of Curve3CrvMetapoolCalculatorLibrary * chore: bumper version to 0.0.6 * hardhat deploy tasks have optional proxy flag (#85) * feat: added optional proxy flag to contract deployments so only the implementation can be deployed * chore: removed unused import in liquidator Hardhat tasks file Co-authored-by: Nick Addison <nick@addisonbrown.com.au> Co-authored-by: tushargargght <tushargargght@gmail.com> Co-authored-by: doncesarts <doncesarts@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LiquidatorImmutableModuleInitializableReentrancyGuardCurve3CrvMetapoolCalculatorLibraryImmutableModuleupdateAssetPerShareandchargePerformanceFeeto fork tests