src/main.sh: Add --experimental-features and --extra-experimental-features support #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShamrockLee
changed the title
ShamrockLee
force-pushed
the
experimental-features
branch
from
00ed107
to
c8192ed
Compare
ShamrockLee
changed the title
ShamrockLee
force-pushed
the
experimental-features
branch
from
c8192ed
to
9da16d6
Compare
|
@msteen Can you please merge this and tag a new release? |
ShamrockLee
force-pushed
the
experimental-features
branch
from
9da16d6
to
571ec2d
Compare
|
Describe the changes inside the |
|
@msteen Could you help take a look? |
* Default to using --extra-experimental-features
instead of --experimental-features
to show respect to the environment configuration.
* Add flags --extra-experimental-features and --experimental-features
to allow manual specification to the experimental-features setting
(e.g. use `builtins.getFlake` when not globally enabled).
ShamrockLee
force-pushed
the
experimental-features
branch
from
571ec2d
to
c5744ef
Compare
|
I accidentally base the CHANGELOG.md work on a non-relevant commit. Just solve the problem. |
|
Any news on this? I'd love to be able to generate a new vendor SHA for packages built with |
m15a
added a commit
to m15a/flake-awesome-neovim-plugins
that referenced
this pull request
May 10, 2024
Hopefully fixes: #130 Even though nix-installer-action enables flakes by default, it is overrided by nix-prefetch since it sets `--experimental-features`. See msteen/nix-prefetch#34
|
This repo hasn't seen activity in 3 years, it's time for a fork. |
|
@eclairevoyant Considering that this project is mission-critical to Nixpkgs, it sounds reasonable to either merge it into Nixpkgs or move it under the nix-community organization. How should we proceed with the forking? I opened an issue about this two years ago (#40). We could discuss it there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to using --extra-experimental-features
instead of --experimental-features
to show respect to the environment configuration.
Add flags --extra-experimental-features and --experimental-features
to allow manual specification to the experimental-features setting
(e.g. use
builtins.getFlakewhen not globally enabled).Fixes #35