Can't disable elcord-mode #4
Comments
|
@ShadowMitia Hm, looks like we forgot to disable the reconnection code once the mode is disabled |
|
@ShadowMitia This should be fixed in the latest commit (0cef4ca)! |
|
It disconnects fine now, thanks! But once disconnected it still shows the last update in the Rich Presence in Discord. And it doesn't seem to be going away even after waiting for a while... On the plus side it doesn't update when changing buffers at all! The only way to make the Rich Presence go back to normal right now is by either quitting emacs or stopping the daemon if running with it. |
|
Hm, something tells me that might be more on Discord's end than anything... See if you can take a screenshot of the console in the inspector ( |
|
Sorry if this is giving you a headache^^
Everything looks fine, except that last line with 'RunningGameStore' that only appears after I quit emacs :/ Let me know if I can give you more information! Wish I could help more, but I don't know too much about elisp yet... |
|
Hm, it looks like it might just be Discord tracking the pid we send in the SET_ACTIVITY packet.... I don't think we can actually do anything about that aside from spawning a process that does nothing, using its pid, and killing it after disconnecting |
|
Yeah, sounds like Discord Rich Presence was not designed for this... But if it tracks the PID I understand it not working when in daemon mode, but it does the same when emacs is run in standalone. Shouldn't it detect emacs not running anymore then? Maybe I did something, I should probably double check.... |
|
@ShadowMitia Huh? I'm not sure you understand what I'm saying... I'm trying to say that the mode being disabled currently acts funny because Discord doesn't stop recognizing emacs as being played until the pid we send it is killed, even if we completely disconnect it from Discord's RPC server |
|
Right, yeah my bad.... Silly remark... You said to use a dummy process for its PID earlier, but couldn't you have elcord run in that process directly instead? Then you wouldn't have a dummy process^^ |
|
@ShadowMitia Yeah, but that'd require us to either call a headless emacs and somehow get our information back and forth which imo seems like a kludgy solution... My thought was running something like |
|
Keeping in mind that I'm very new at elisp, and bad at processes, but couldn't having an asynchronous process solve everything? In any case, I think I've made this issue diverge sufficiently from its original purpose^^ You should probably close this. I'm sure a solution will turn up someday^^ |
|
@ShadowMitia I finally figured out how to do this! After checking the source, we can actually send |
|
@Mstrodl Congrats! Thanks for working on this issue! I hope it didn't give you any sleepless nights 😁 |
|
@ShadowMitia No worries, it's more that I stumbled upon it :P |
I can't seem to be able to disable
elcord, I tried callingelcord-modebut it still sends updadtes to the Rich Presence, however long I wait. Calling it several times does not seem to help either.Extract from my
*messages*:I'm using Fedora 27 and Emacs 25.3.1
The text was updated successfully, but these errors were encountered: