feat: enable esm export of package #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE enable esm support
1 task
|
@kettanaito I pushed to this branch, to also use the |
kettanaito
approved these changes
Oct 6, 2022
Released: v1.0.0 🎉This has been released in v1.0.0! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE enable esm support
(accidentally closed that one)
superceedes #25
Expose cookies esm build.
Added tsup, and config similar to other msw related libraries
Once this was done, there were some bundle related issues, since set-cookie-parser is only released as commonjs.
In order to support this, we bundle that library by moving it into devDependencies instead of declaring it as a dependency. By default, tsup treats all 'dependencies' as external in an esm build, so this is not necessarily standard, but works to ensure that this library is treated as esm compatible.