Updates the Storybook example #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests will fail due to storybookjs/storybook#13801 |
kettanaito
force-pushed
the
storybook/update
branch
from
da01832
to
48d0bad
Compare
kettanaito
commented
Feb 3, 2021
| // Export the worker instance, so we can await the activation on Storybook's runtime. | ||
| // You can use this reference to start the worker for local development as well. | ||
| export const worker = | ||
| typeof global.process === 'undefined' && setupWorker(...handlers) |
There was a problem hiding this comment.
This is a mess. I've raised it here storybookjs/storybook#11378 (comment) to see if there's a better way.
Each story executes both in NodeJS and in a browser. I see no way to import the worker in a browser only.
|
I'm disabling the test until the CSS loading issue with |
kettanaito
changed the title
kettanaito
commented
Feb 4, 2021
| @@ -2,27 +2,27 @@ | |||
| "name": "with-storybook", | |||
| "version": "0.0.0", | |||
| "scripts": { | |||
| "storybook": "start-storybook -p 6006 -s public", | |||
| "storybook": "start-storybook -h localhost -p 6006 -s public", | |||
There was a problem hiding this comment.
Storybook started to open at an absolute address now. MSW cannot be registered on an absolute address unless you a) whitelist that addresse as secure, b) load that address via HTTPS. Both options are overcomplicated for the example's purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STORY.decoratorsfor per-story API mocks.