Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): include "graphql" as a dependency #1381

Merged
merged 5 commits into from
Sep 1, 2022

Commits on Aug 30, 2022

  1. fix(package.json): make graphql non-optional peerDependency

    this makes the graphql peer dependency required. While the hope is to eventually avoid the need to
    require the graphql library for users who don't declare graphql requests directly, the current
    architecture means that many tools fails to properly compile without error/warning without this.
    
    Since NPM 7, npm will automatically install peer dependencies, which should avoid consumers of msw
    having to manually install graphql.
    
    re mswjs#1371
    mattcosta7 committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    212ebb3 View commit details
    Browse the repository at this point in the history
  2. refactor: graphql imported by import instead of require

    removes the previous attempt at making graphql optional by lazily requiring it instead of importing
    it.  This didn't have the intended affect of helping to avoid parsing in many environments, and
    might be confusing and/or cause friction with a future migration to using native modules and
    providing an export that can be treeshaken in all environments.
    
    re mswjs#1371
    mattcosta7 committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    618989d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1dbc669 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a1564c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Configuration menu
    Copy the full SHA
    b26c2f1 View commit details
    Browse the repository at this point in the history