feat: export browser integration from "msw/browser" #1591
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
setupWorker
and its types) is now exported undermsw/browser
.msw
root-level export only exports primitives and utilities. No integrations there.Why this change?
I want to ship proper ESM support and CJS support for older bundlers. With ESM it's pretty clear, and it's been addressed in #1584. The problem is TypeScript. With conditional exports, TS will not know what environment is the module you're writing:
Because TS will assume Node and will resolve
msw
under Node module resolution, respecting itsexports
, where nosetupWorker
types are exported inlib/node/index.d.ts
(rightfully).To ship this CJS/ESM support, we must provide the export pattern that will not make TypeScript confused. Instead of diving into another half a year of work to restructure this into a monorepo, I'm falling back to a
/browser
directory export:/browser
directory).