-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add more browsers to playwright config #1776
base: main
Are you sure you want to change the base?
Conversation
Welp, looks like a bunch of failing tests 😅 That's a lot more than I was expecting though, I was expecting maybe a couple. Im not sure if I'll have time to address all of these today, but ill try to dive in sometime this week |
@thepassle, we can address those together in our spare time. MSW as it is doesn't promise nor offer any particular browser support. I always saw MSW as a devtool, and if it doesn't work in one browser simply switch to another and work with it there (similar to how every browser has different devtools available). That being said, I do find great value in cross-browser testing and we should pursue this endeavor. I think we can improve how browser tests run in CI so it's more apparent what browser corresponds to what failed tests, as well as parallelize cross-browser runs since GitHub Actions has 1 thread and will run all tests for all browsers sequentially. Browser tests already take the most time on CI, and if we add more browser targets, we have to likely introduce separate GitHub workflows for those so they can run in parallel and save us some time. |
Yeah there's no rush to getting this in, but it would definitely be nice in general to improve the browser support for the library.
At ING we encourage our developers to test their code on multiple browsers, developers can do this manually during local dev, but also often teams use automated testing via While I agree that MSW shouldn't have to bend over backwards to support IE11, but I don't think its unreasonable to at least make sure the library works on the latest version of the major browsers (chromium/firefox/safari).
Sounds good! Like I mentioned, there's no rush to get this in. Ill try to find some time this week to start chipping away at this :) |
Absolutely agree. |
bd6f65a
to
9acafde
Compare
No description provided.