feat: up tsconfig target for more modern syntax

[thepassle]

No description provided.

[thepassle]

Ok well I expected this to be a more impactful change, but it seems everything seems to be working just fine :) gave this a quick spin on our example app and everything works, tested on ff/safari/chrome, tested on node 18, didnt run into any issues, so I think we can go ahead and merge this if you agree.

output looks a lot better, and will make debugging a lot easier :)

[kettanaito]

I recall some tooling, I think it was Cypress, that has trouble consuming modern JavaScript. They require third-parties to be CommonJS. @thepassle, should that be our concern?

[thepassle]

This sounds a little odd to me. A browser launcher expects code to be cjs? 🫠

[kettanaito]

I've updated the branch. The change itself looks great, just need to make sure we aren't breaking third parties that cannot digest modern JavaScript. @thepassle, may I ask you to give this WIP build a try in our Examples repo? If all those pass, then we have nothing to worry about,

[thepassle]

I've updated the branch. The change itself looks great, just need to make sure we aren't breaking third parties that cannot digest modern JavaScript. @thepassle, may I ask you to give this WIP build a try in our Examples repo? If all those pass, then we have nothing to worry about,

Is the Examples repo main branch up to date? I cloned it and pnpm installed, but im getting failed tests without making any changes:

[kettanaito]

@thepassle, the examples repo needed the upgrade to msw@2.0. Just merged that upgrade, the tests are passing. You can give this build a try there.

I will also spend some time bringing back smoke tests but will make them on-demand (they are way too expensive to be run in CI on each change but it's a good idea to run them on changes where we expect the unexpected, like this one).

[thepassle]

Alright cool, thanks. I'll give this another try today

[kettanaito]

I've merged the smoke test workflow (as well as the bash script for local runs) so we should be able to run any PR against the examples repo easier now. I will update this branch and give it a try.

[thepassle]

I've merged the smoke test workflow (as well as the bash script for local runs) so we should be able to run any PR against the examples repo easier now. I will update this branch and give it a try.

cool, thanks, let me know if theres anything I can help with :)

[kettanaito]

@thepassle, do you happen to know how to allow the same GitHub workflow to run with both workflow_run and workflow_dispatch hooks?

I would like for the smoke-test workflow to trigger in two situations:

• If the ci job completes successfully on main.
• If it has been manually started (workflow_dispatch).

I have the following config:

on:
  # Always run smoke tests upon a successful
  # "ci" job completion on "main".
  workflow_run:
    workflows: ['ci']
    branches: [main]
    types: [completed]
  workflow_dispatch:

jobs:
  examples:
    if: ${{ github.event.workflow_run.conclusion == 'success' || github.event.workflow_dispatch }}

But GitHub doesn't seem to evaluate the jobs.examples.if expression correctly. Perhaps I'm writing it wrong.

[thepassle]

I don't have a whole bunch of experience with github actions, but this is what github copilot tells me 😛

The github.event.workflow_dispatch event does not have a conclusion property. The conclusion property is only available for the workflow_run event.

If you want to run the job when the workflow_run event's conclusion is success or when the workflow_dispatch event is triggered, you can use the github.event_name property to check which event triggered the workflow. Here's an updated version of your code:

on:
  workflow_run:
    workflows: ['ci']
    branches: [main]
    types: [completed]
  workflow_dispatch:

jobs:
  examples:
    if: ${{ (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success') || github.event_name == 'workflow_dispatch' }}

This will run the job when the workflow_run event's conclusion is success or when the workflow_dispatch event is triggered.

[kettanaito]

@thepassle, thanks! That seems to be working (at least it doesn't discard the manual runs). Started a smoke test on this branch: https://github.com/mswjs/msw/actions/runs/6730818633

[thepassle]

Hehe nice

Fingers crossed 🙂

[kettanaito]

The smoke tests are passing. I deem this change worthy. Let's add it to the next minor version bump.

[thepassle]

Looking good

[kettanaito]

Will schedule this in the next minor version.

[kettanaito]

Updated the examples to use 2.0.14. Re-running the smoke tests against these changes and then merging.

[kettanaito]

Alas, the smoke tests are broken :( Passes locally, passes in the Examples repo, fails miserably in the smoke-test job. Has to do with Playwright, only PW-based examples fail. Tried installing PW browsers literally at any place I could, no help.

[kettanaito]

Released: v2.1.0 🎉

This has been released in v2.1.0!

• 📄 Release notes
• 📦 npm package

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.

---

Predictable release automation by @ossjs/release.