Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GraphQLHandler): move cookie parsing to parse phase #1957

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

mattcosta7
Copy link
Contributor

Moves getAllRequestCookies parsing in GraphQLHandler from extendResolverArgs to parse step.

This normalizes its usage with that of HttpHandler.

Also updates tests to account for this

@mattcosta7 mattcosta7 marked this pull request as ready for review January 8, 2024 04:19
@mattcosta7 mattcosta7 self-assigned this Jan 8, 2024
Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you 🚀

@kettanaito kettanaito merged commit ba87f99 into main Jan 12, 2024
11 checks passed
@kettanaito kettanaito deleted the move-graphql-cookies-to-parse-phase branch January 12, 2024 14:48
@kettanaito
Copy link
Member

Released: v2.0.14 🎉

This has been released in v2.0.14!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants