fix: improve custom request handler and resolver annotations #1961
Conversation
kettanaito
commented
Jan 11, 2024
•
kettanaito
commented
- Fixes Custom response resolver annotations #1955
- Solves How to type async higher-order resolver in Typescript? #1802
| @@ -10,22 +10,35 @@ import { | |||
| } from './handlers/HttpHandler' | |||
| import type { Path, PathParams } from './utils/matching/matchRequestUrl' | |||
|
|
|||
| export type HttpRequestHandler = < | |||
There was a problem hiding this comment.
Confusing terminology here.
HttpRequestHandleris when people want to create customhttp.get()function.HttpHandleris nothttp.get()interface at all. It's its own thing with.parse(),.run()and friends.
I think in the context of the userland, it's fine to call this type a request handler type. It's precisely how we refer to the http.get() functions in the docs.
|
Hi, @mattcosta7 👋 Please, would you have a minute to give this change a brief look? The aim here is to improve the way people can annotate custom request handlers and response resolvers in TypeScript by shipping a few utility types. |
Will do, might not have time to look much until this weekend, but i'll try to get eyes on it sooner! |
| | MaybeAsyncResponseResolverReturnType<BodyType> | ||
| export type AsyncResponseResolverReturnType< | ||
| ResponseBodyType extends DefaultBodyType, | ||
| > = MaybePromise< |
There was a problem hiding this comment.
This is a fantastic change suggested by @Andarist to enable proper return type inference when annotating custom higher-order resolvers. Gold.
Released: v2.0.14 🎉This has been released in v2.0.14! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
