Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use a lightweight "@inquirer/confirm" in the CLI #2020

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

sairus2k
Copy link
Contributor

@sairus2k sairus2k commented Feb 6, 2024

This PR updates cli/init.js by replacing the inquirer package with the lighter @inquirer/confirm module, following inquirer's recent modular rewrite. This change aims to reduce our package size and enhance CLI performance.

Changes:

  1. Removed inquirer from dependencies.
  2. Added @inquirer/confirm to dependencies.
  3. Refactored cli/init.js to work with the new module's API.
  4. Optimized then callback in the function 'promptWorkerDirectoryUpdate'.

@sairus2k sairus2k changed the title Replace 'inquirer' with '@inquirer/confirm' in cli/init.js chore: replace 'inquirer' with '@inquirer/confirm' in cli/init.js Feb 6, 2024
Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Let's run the tests and have this prepared for the next minor release. Thank you, @sairus2k! 🚀

@kettanaito kettanaito changed the title chore: replace 'inquirer' with '@inquirer/confirm' in cli/init.js feat: use a lightweight "@inquirer/confirm" in the CLI Feb 6, 2024
@kettanaito kettanaito merged commit f25af8a into mswjs:main Feb 12, 2024
10 checks passed
@kettanaito
Copy link
Member

Released: v2.2.0 🎉

This has been released in v2.2.0!

Make sure to always update to the latest version (npm i msw@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants