fix(WebSocketClientManager): use localStorage for clients persistence #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
changed the title
28 tasks
kettanaito
commented
Apr 12, 2024
| if (typeof localStorage !== 'undefined') { | ||
| // When the worker clears the local storage key in "worker.stop()", | ||
| // also clear the in-memory clients map. | ||
| localStorage.removeItem = new Proxy(localStorage.removeItem, { |
There was a problem hiding this comment.
Ideally, we would know when worker.stop() is called but the manager lives in ws.link() while the stop event is only ever available in handleWebSocketEvent().
This would be an insane context drilling. Instead, let's proxy the localStorage.removeItem() calls.
kettanaito
force-pushed
the
fix/ws-manager-clients
branch
from
aca9f05
to
ee4ca2e
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We have a bug that a new runtime doesn't really know about any other runtimes. It only keeps itself in the list of clients and notifies other runtimes about itself. That's not right.
BroadcastChannel is not a good API to introduce a shared state because one has to constantly keep that state in-sync. Instead, I propose we use
localStorageto keep the serialized list of all the WebSocket clients for the app.Roadmap
src/core/ws/WebSocketClientManager.test.tstests, the constructor signature and the behavior ofWebSocketClientManagerhave changed.