Make pacboy work the same in all envs and only ever map to one package #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From what I see this doesn't change anything, but for completeness
This was to not install mingw64 packages by default on 32bit systems. 32bit is no longer supported, and we want to remove the auto install part for unrelated environments anyway, so this can be removed.
The "!= MINGW*" was likely there to cover the MSYS env, back when there only was MINGW32/64. So that is equal to an empty prefix. For UCRT/CLANG this means it will expand names to mingw packages names like in MINGW32/64, but hardcoded to MINGW32/64, which is probably not what we want, but will be fixed in the next commit. This makes pacboy behave the same under all environments again. See msys2#4
"pacboy -S ffmpeg" would by default install ffmpeg for mingw32 and mingw64. Due to other logic bugs fixed in the last commit this did not apply to other environments, where it would fail because no prefix would be added. Ideally the command would work the same in all environments and would only install for the active environment unless specifically asked for. This changes things so that "pacboy -S ffmpeg" works the same as "pacboy -S ffmpeg:p" did before in all envs. This is a slight breaking change, though I'd argue the current behaviour was unexpected and unlikely to be wanted by users. Fixes msys2#4
Kojoley
reviewed
May 8, 2024
1480c1
reviewed
May 8, 2024
Kojoley
reviewed
May 9, 2024
|
renatosilva#7 suggests that it is a good idea to bump the version in the help output after a behavioral change. |
These install packages for multiple environments. name:l was only added for consistency. It's unlikely someone wants to install for exactly those two environments and it's easy to just use "name:x name:i" instead. They still work, but let's hide them from the help output.
They are not shell specific, so just have one list to simplify.
Also try to make the help text a bit more clear by showing to which names the input gets translated to
done |
Kojoley
approved these changes
May 10, 2024
|
thanks! |
|
Package update @ msys2/MSYS2-packages#4593 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4, see the commits for details. I tried to split it up as best as I can.
Summary: