Try to shorten the release install path a bit #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We created a "msys" dir under RUNNER_TEMP and then added the launcher there and install msys2 under "msys64". This results in an install path of "D:/a/_temp/msys/msys64". Since these paths might end up in command line arguments and those have length limits we should try to keep it short. So install the launcher under "$RUNNER_TEMP/setup-msys2" and msys2 directly under "$RUNNER_TEMP/msys64", so the path becomes "D:/a/_temp/msys64", saving 5 characters.
|
Thanks! |
akiyosi
added a commit
to akiyosi/goneovim
that referenced
this pull request
Oct 15, 2021
This was referenced Oct 16, 2021
jeromerobert
added a commit
to jeromerobert/hmat-oss
that referenced
this pull request
Oct 20, 2021
jeromerobert
added a commit
to jeromerobert/hmat-oss
that referenced
this pull request
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We created a "msys" dir under RUNNER_TEMP and then added the launcher
there and install msys2 under "msys64".
This results in an install path of "D:/a/_temp/msys/msys64". Since these paths
might end up in command line arguments and those have length limits we should
try to keep it short.
So install the launcher under "$RUNNER_TEMP/setup-msys2" and msys2 directly
under "$RUNNER_TEMP/msys64", so the path becomes "D:/a/_temp/msys64",
saving 5 characters.
This is motivated by a qt6 build error hitting the limit. Tough not sure if this is enough of a reduction to make it work... msys2/MINGW-packages#9716