Suggestion: respect default terminal emulator

[polygonica]

Users using ConEmu can configure it to be the system's default terminal emulator. I think it would be a good idea for the "Git Bash" Cheetah option to respect this choice.

[kusma]

What does "the system's default terminal emulator" even mean? Windows doesn't really have a concept of replaceable terminal emulators, so this sounds like ConEmu doing something to divert calls to cmd.exe (or something similar). Git Bash doesn't start cmd.exe, so I don't think such a concept would even work, and even if it would it'd probably be an issue with ConEmu's implementation of that concept.

[dscho]

Having said that, I could imagine that somebody motivated enough (@polygonica, this is a hint for you!) could make it configurable which terminal emulator is offered.

[polygonica]

I did some digging around in the source. It looks like create_bash_argv in explorer/menu.c handles the command for the creation of the new window and pulls the cmd it uses from get_cmd. Is there a particular reason the command is "start sh" and not just "sh"? Forcing the creation of a new window with start seems to trip up ConEmu but doesn't seem to have any purpose in the stock setup.

(Removing one parameter is simpler than allowing user configuration)

[kusma]

There's a comment at the top of that function saying "start is required because exec_program does not create a window", originating from 915e185.

[polygonica]

Missed that -- thanks. I'll see if I can patch configuration in then.