Update utils.ex #111
Merged
Update utils.ex #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [docs for ensure_compiled](https://hexdocs.pm/elixir/1.13/Code.html#ensure_compiled/1) specifically warn against doing this. To quote: > If the module being checked is currently in a compiler deadlock, this function returns {:error, :unavailable}. Unavailable doesn't necessarily mean the module doesn't exist, just that it is not currently available, but it (or may not) become available in the future. Therefore, if you can only continue if the module is available, use ensure_compiled!/1 instead. In particular, do not do this: ```elixir case Code.ensure_compiled(module) do {:module, _} -> module {:error, _} -> raise ... end ```
|
Nice, thanks! Could you just rebase against latest master so the new workflow passes? I'll then merge it ASAP. |
|
Actually, I just tested the merge locally and this is good to go 👍 |
|
Apologies just getting to this now! Glad it was okay then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs for ensure_compiled specifically warn against doing this. To quote:
What do you think about using
ensure_compiled!instead?