-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing coloured kitchen cabinets #73
Conversation
…registration of dye recipes to show item craft first before recipe craft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this registration should be next to the node def, not buried here since its for the one specific node
Understood and applied. I would like to add, having the unifieddyes registration within the homedecor_common/register.lua file could be useful to fix the ordering of recipe outputs of those with the ud_param2_colorable group. |
not sure why your overriding the method, instead of just calling the crafting function itself |
It's a temporary override. After the cabinets are registered, it gives back the old_homedecor_register function to homedecor.register, and no other items are registered with the override function. It is to get the cabinet's item names and call unifieddyes.register_color_craft before the cabinets are registered. I'm not sure how else to get all the different item names and register the color craft before the node craft, short of adding a call to register_color_craft above each node registration. |
there is this loop: https://github.com/mt-mods/homedecor_modpack/blob/master/homedecor_kitchen/init.lua#L164 or homedecor.kitchen_convert_nodes which could be looped over to register the craft |
Maybe moving the table insertions before the cabinet_materials traversal would work. I'll giver a shot and see |
I'm sorry, there is no way to accomplish your request. |
Addresses cabinets missing in issues #4 and #41
Coloured cabinets are craftable after applying patch,