Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing coloured kitchen cabinets #73

Closed
wants to merge 5 commits into from

Conversation

monk-afk
Copy link
Contributor

Addresses cabinets missing in issues #4 and #41

image

Coloured cabinets are craftable after applying patch,
image
image

Copy link
Collaborator

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this registration should be next to the node def, not buried here since its for the one specific node

@monk-afk monk-afk requested a review from wsor4035 May 24, 2024 05:35
@monk-afk
Copy link
Contributor Author

Understood and applied.

I would like to add, having the unifieddyes registration within the homedecor_common/register.lua file could be useful to fix the ordering of recipe outputs of those with the ud_param2_colorable group.

@wsor4035
Copy link
Collaborator

not sure why your overriding the method, instead of just calling the crafting function itself

@monk-afk
Copy link
Contributor Author

It's a temporary override. After the cabinets are registered, it gives back the old_homedecor_register function to homedecor.register, and no other items are registered with the override function.

It is to get the cabinet's item names and call unifieddyes.register_color_craft before the cabinets are registered.

I'm not sure how else to get all the different item names and register the color craft before the node craft, short of adding a call to register_color_craft above each node registration.

@wsor4035
Copy link
Collaborator

there is this loop: https://github.com/mt-mods/homedecor_modpack/blob/master/homedecor_kitchen/init.lua#L164 or homedecor.kitchen_convert_nodes which could be looped over to register the craft

@monk-afk
Copy link
Contributor Author

homedecor.kitchen_convert_nodes is a table populated with the nodes after they are registered.

Maybe moving the table insertions before the cabinet_materials traversal would work.

I'll giver a shot and see

@monk-afk
Copy link
Contributor Author

I'm sorry, there is no way to accomplish your request.

@monk-afk monk-afk closed this May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants