Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if message is found in mail.show_message #116

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

BuckarooBanzay
Copy link
Member

checks if the message to display is non-nil and skips the formspec part if it is nil

the cause of the nil messages could be some race-condition in the show/callback logic of the formspecs, until this is proven and can be reproduced this will fix #115 and any other nil-message related crash

@Athozus Athozus merged commit 2111db2 into master Oct 23, 2023
20 checks passed
@Athozus Athozus added this to the 1.4.0 milestone Mar 22, 2024
@Athozus Athozus deleted the show_message-check-nil branch April 15, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

server crash attempt to index local 'message' (a nil value)
2 participants