Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple selection #60

Merged
merged 8 commits into from
Apr 12, 2023
Merged

Add multiple selection #60

merged 8 commits into from
Apr 12, 2023

Conversation

Athozus
Copy link
Member

@Athozus Athozus commented Apr 10, 2023

This merge request adds support for multiple selection. There are no issues from my tests.

Tell me your feedbacks.

@Athozus Athozus added the Enhancement New feature or request label Apr 10, 2023
@Athozus Athozus added this to the 1.1.0 milestone Apr 10, 2023
@Athozus Athozus requested a review from S-S-X April 10, 2023 17:40
S-S-X
S-S-X approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@S-S-X S-S-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

Also reminder: would be good to start adding some tests for formspec actions but open another pull request for this.

@Athozus Athozus mentioned this pull request Apr 11, 2023
Closed
@Athozus
Copy link
Member Author

Athozus commented Apr 11, 2023

I've fixed issues reported by #61. It works for me, and we no longer have to load all messages in message.lua so that's great. @S-S-X , could you try some things and tell me your report ? It will be the last MR until 1.1.0 (I don't consider updating about as a "real" MR).

@Athozus Athozus requested a review from S-S-X April 11, 2023 19:15
@Athozus
Copy link
Member Author

Athozus commented Apr 12, 2023

This issue would :

Close #43
Close #61

This was linked to issues Apr 12, 2023
Improved messages selection #43
Closed
Reply to message pulls a different message than the one selected #61
Closed
S-S-X
S-S-X reviewed Apr 12, 2023
View reviewed changes
ui/outbox.lua Show resolved Hide resolved
@Athozus
Copy link
Member Author

Athozus commented Apr 12, 2023

If it's ok for you (due to the last comment), I merge.

S-S-X
S-S-X reviewed Apr 12, 2023
View reviewed changes
locale/mail.de.tr.old Outdated Show resolved Hide resolved
S-S-X
S-S-X reviewed Apr 12, 2023
View reviewed changes
ui/inbox.lua Outdated Show resolved Hide resolved
S-S-X
S-S-X reviewed Apr 12, 2023
View reviewed changes
ui/outbox.lua Outdated Show resolved Hide resolved
@S-S-X
Copy link
Member

S-S-X commented Apr 12, 2023

Seems good but again I've not actually tested anything.
But anyway considering #61 should be fixed I guess it can't really be much worse even if there would be some bugs... so I'd say good for merge.

@Athozus Athozus merged commit 191e511 into mt-mods:master Apr 12, 2023
@Athozus Athozus deleted the feature/multiple-selection branch April 15, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S-S-X S-S-X S-S-X approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Reply to message pulls a different message than the one selected Improved messages selection
2 participants
@Athozus @S-S-X