Machines conduct digilines above #194
Conversation
Click for detailed source code test coverage reportTest coverage report for Technic CNC 79.43% in 8/8 files:Test coverage report for technic 9.55% in 10/102 files:Raw test runner output for geeks:CNC: Technic: |
Uhm, yeah: it is, not sure how 4 eyes could have missed that 🤦 |
|
Well, simply just revert but where did idea came from as that was exact rule added long ago? Is there possibly problems with it currently? |
|
Actually it seems that is to conduct from above, that was left out last intentionally. Don't remember what were reasons.... I mean change (with comments) were, "along y above": {x = 0, y = -1, z = 0}, -- along y below
+ {x = 0, y = -1, z = 0}, -- along y aboveedit. here #43 and I think it was left out because cables should not connect to most machines from above and custom rules were primarily for digicables while also keeping it as backwards compatible with in world builds as possible, fix for that #124 |
|
It seems odd visually for Supply Converter then when power digi cable goes to the input (top) but digiline signal on that power digi cable is not connected to the Supply Converter. At least for Supply Converter it should connect from above so the behavior matches what the player is looking at, a power digi cable goes into the top input it should then have a connection to digiline and power not just power only. |
|
🤦 I still think it makes sense for machines to conduct above, because they can be powered from above. |
Yes, there's few machines that should for sure allow connection from above. At least ones that also allow connecting cables from above, but if going with cable connections then for most machines / generic rules machines should not connect digilines from above.
These are bugs and not meant to work this way. That reasoning is not valid in my opinion as you're basically saying that connection should be allowed because cable connections are also broken. That said when I added custom digiline rules only reason why I did not want to add connection directly above was to avoid problems with excessive messages sent to digiline network where you do not expect those but other than that I'm not against adding connection from above. These connections are also documented, also if you missed it linking again to bug fix ticket #124 For most machines intended cable connections are similar to "base machine" (or even less than, like bb): |
I think it would be fine, after all this is only to connect machines to digilines, machines don't conduct digilines through themselves.
And yet they conduct digilines on the front... Also, we're forgetting that digilines also exists separate from cables, in particular digimese that conducts downwards. |
Because that is one of default digiline connections but directly above and below are not, I've even written comment about that in technic digiline definition.
We are not forgetting that, it just is most common to have cables below machines and very uncommon to have cables above machines. This is partly due to how cables are supposed to work. Basically for new connections below the machine was clearly safest option that made newly added digicables a lot more useful for connecting machines normal way. |
No description provided.