Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set up GitHub Actions #41

Closed
3 tasks
Tracked by #23
mt7180 opened this issue Oct 9, 2023 · 4 comments · Fixed by #46
Closed
3 tasks
Tracked by #23

set up GitHub Actions #41

mt7180 opened this issue Oct 9, 2023 · 4 comments · Fixed by #46

Comments

@mt7180
Copy link
Owner

mt7180 commented Oct 9, 2023

Transferred from #23

Second MR:

@mt7180 mt7180 mentioned this issue Oct 9, 2023
6 tasks
@mt7180
Copy link
Owner Author

mt7180 commented Oct 10, 2023

@Zaubeerer:
I would go with the following yml file in .github/workflows/:

name: code_quality_checks

on: [push]

jobs:
lint_with_black_n_ruff:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: psf/black@stable
- uses: chartboost/ruff-action@v1

Question: do I have to additionally run python and black/ ruff like so?!:

  - run: |
      python -m pip install --upgrade pip
      pip install -r requirements.txt
  - run: |
      black --check --verbose .

@Zaubeerer
Copy link
Collaborator

At first glance that looks good.

Feel free to create a PR and try it ;-)

@mt7180
Copy link
Owner Author

mt7180 commented Oct 15, 2023

@Zaubeerer : So this means you would or would not include the last run commands?

@Zaubeerer
Copy link
Collaborator

Yes, include the two 👍

@mt7180 mt7180 linked a pull request Oct 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants