Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set-up app #1

Merged
merged 6 commits into from
Sep 21, 2023
Merged

set-up app #1

merged 6 commits into from
Sep 21, 2023

Conversation

mt7180
Copy link
Owner

@mt7180 mt7180 commented Sep 20, 2023

No description provided.

@mt7180 mt7180 self-assigned this Sep 20, 2023
mt7180
mt7180 commented Sep 20, 2023
View reviewed changes
Copy link
Owner Author

@mt7180 mt7180 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question

backend/fastapi_app.py Outdated Show resolved Hide resolved
Zaubeerer
Zaubeerer requested changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@Zaubeerer Zaubeerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to make at least a couple of these changes before merging into main

.gitignore Show resolved Hide resolved
POC_langchain/query_text_files.ipynb Show resolved Hide resolved
POC_langchain/requirements.txt Outdated Show resolved Hide resolved
backend/Dockerfile Show resolved Hide resolved
POC_langchain/README.md Outdated Show resolved Hide resolved
backend/fastapi_app.py Outdated Show resolved Hide resolved
backend/fastapi_app.py Outdated Show resolved Hide resolved
backend/fastapi_app.py Show resolved Hide resolved
backend/fastapi_app.py Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
@mt7180
Copy link
Owner Author

mt7180 commented Sep 21, 2023

I implemented all your suggested code adjustments and pushed them into the dev branch here on Github. Thanks!

Zaubeerer
Zaubeerer approved these changes Sep 21, 2023
View reviewed changes
frontend/streamlit_app.py Show resolved Hide resolved
This was referenced Sep 21, 2023
Closed
Closed
@Zaubeerer
Copy link
Collaborator

Feel free to merge the PR :)

@mt7180 mt7180 merged commit f70444a into main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zaubeerer Zaubeerer Zaubeerer approved these changes

Assignees

@mt7180 mt7180

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mt7180 @Zaubeerer